Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_spot_fleet_request: Capture additional IAM eventual consistency error during RequestSpotFleet #14358

Merged
merged 1 commit into from
Jul 29, 2020
Merged

resource/aws_spot_fleet_request: Capture additional IAM eventual consistency error during RequestSpotFleet #14358

merged 1 commit into from
Jul 29, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 27, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #14265

Release note for CHANGELOG:

NONE

Caught before it was released via daily acceptance testing.

Previously (inconsistently!):

TestAccAWSSpotFleetRequest_iamInstanceProfileArn: testing.go:684: Step 0 error: errors during apply:
Error: Error requesting spot fleet: InvalidSpotFleetRequestConfig: The provided SpotFleetRequestConfig.IamFleetRole does not have permission to call DescribeSubnet.

Output from acceptance testing:

--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (357.30s)
--- PASS: TestAccAWSSpotFleetRequest_basic (345.77s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (624.59s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (282.46s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (862.86s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (347.01s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (345.46s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (292.74s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (140.49s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (142.89s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (552.78s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (212.21s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (203.07s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (624.12s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (273.68s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (253.37s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (347.63s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (253.01s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (548.08s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (253.77s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (262.55s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (535.56s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (60.24s)
--- PASS: TestAccAWSSpotFleetRequest_tags (282.26s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (624.59s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (970.38s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (230.13s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (284.19s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (525.74s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (270.52s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (432.60s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (252.23s)

@bflad
resource/aws_spot_fleet_request: Capture additional IAM eventual cons…
d70a6ff 
…istency error during RequestSpotFleet

Reference: #14265

Previously (inconsistently!):

```
TestAccAWSSpotFleetRequest_iamInstanceProfileArn: testing.go:684: Step 0 error: errors during apply:
Error: Error requesting spot fleet: InvalidSpotFleetRequestConfig: The provided SpotFleetRequestConfig.IamFleetRole does not have permission to call DescribeSubnet.
```

Output from acceptance testing:

```
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (357.30s)
--- PASS: TestAccAWSSpotFleetRequest_basic (345.77s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (624.59s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (282.46s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (862.86s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (347.01s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (345.46s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (292.74s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (140.49s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (142.89s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (552.78s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (212.21s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (203.07s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (624.12s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (273.68s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (253.37s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (347.63s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (253.01s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (548.08s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (253.77s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (262.55s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (535.56s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (60.24s)
--- PASS: TestAccAWSSpotFleetRequest_tags (282.26s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (624.59s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (970.38s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (230.13s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (284.19s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (525.74s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (270.52s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (432.60s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (252.23s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 27, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 27, 2020
@bflad bflad requested a review from a team July 27, 2020 19:10
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jul 27, 2020
@anGie44 anGie44 self-requested a review July 28, 2020 14:59
anGie44
anGie44 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad merged commit f8731c0 into master Jul 29, 2020
@bflad bflad deleted the b-aws_spot_fleet_request-additional-iam-retries branch July 29, 2020 12:11
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @anGie44